[LLVM] integrate upstream SMT #8408
Merged
+75
−2,818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
force-pushed
the
makslevental/integrate-upstream-smt
branch
4 times, most recently
from
3a81a31 to
05a2409
Compare
makslevental
requested review from
TaoBi22,
dtzSiFive,
fabianschuiki,
fzi-hielscher,
math-fehr and
mikeurbach
makslevental
force-pushed
the
makslevental/integrate-upstream-smt
branch
from
05a2409 to
3b4189b
Compare
TaoBi22
approved these changes
Apr 14, 2025
Contributor
TaoBi22
left a comment
TaoBi22
left a comment
There was a problem hiding this comment.
This looks good to me, thanks!
| ConversionPatternRewriter &rewriter) const override { | ||
| rewriter.replaceOpWithNewOp<smt::RepeatOp>(op, op.getMultiple(), | ||
| adaptor.getInput()); | ||
| rewriter.replaceOpWithNewOp<mlir::smt::RepeatOp>(op, op.getMultiple(), |
Contributor
There was a problem hiding this comment.
Is there a reason to not just using namespace mlir in this file?
Contributor
Author
There was a problem hiding this comment.
At first I did that but then I couldn't tell what convention you guys are following - whether code outside of CIRCT should be fully qualified. If you say using namespace mlir is ok that's good enough for me!
Contributor
There was a problem hiding this comment.
I'm definitely not an authority on our style conventions, but it looks like plenty of conversion passes use it!
maerhart
approved these changes
Apr 14, 2025
Member
maerhart
left a comment
maerhart
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing the integration!
makslevental
force-pushed
the
makslevental/integrate-upstream-smt
branch
from
e75ef0e to
c930fe2
Compare
makslevental
force-pushed
the
makslevental/integrate-upstream-smt
branch
from
c930fe2 to
e32b67b
Compare
RonxBulld
pushed a commit
to RonxBulld/hs-circt
that referenced
this pull request
Apr 15, 2025
KelvinChung2000
pushed a commit
to KelvinChung2000/circt
that referenced
this pull request
Apr 22, 2025
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps LLVM to the
maincommit associated with llvm/llvm-project#131480. The only non-upstreaming-SMT change is the small change in test/Dialect/Moore/types-errors.mlir.Note, the upstream PR was only for the dialect itself. Shortly I will send subsequent PRs to move all of the other SMT stuff (ExportSMITLib, CAPI, Python bindings).